Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC 11: Double Signer Slashing #336

Merged
merged 8 commits into from
Aug 18, 2023
Merged

RFC 11: Double Signer Slashing #336

merged 8 commits into from
Aug 18, 2023

Conversation

DhairyaSethi
Copy link
Contributor

No description provided.

Stefan-Ethernal
Stefan-Ethernal approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ZeroEkkusu
ZeroEkkusu approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@ZeroEkkusu ZeroEkkusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits (as discussed); LGTM otherwise.

@coveralls
Copy link

coveralls commented Aug 18, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5901522385

  • 2 of 30 (6.67%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 77.972%
Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/child/validator/ValidatorSet.sol 0 14 0.0%
contracts/root/staking/CustomSupernetManager.sol 0 14 0.0%
Totals Coverage Status
Change from base Build 5820355640: -0.7%
Covered Lines: 1369
Relevant Lines: 1710
💛 - Coveralls

@DhairyaSethi DhairyaSethi merged commit e025e70 into dev Aug 18, 2023
7 checks passed
@DhairyaSethi DhairyaSethi deleted the feat/slashing branch August 18, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@ZeroEkkusu ZeroEkkusu ZeroEkkusu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DhairyaSethi @coveralls @Stefan-Ethernal @ZeroEkkusu